unRAID OS version 6.3.0 Stable Release Available


limetech

Recommended Posts

Download

 

Clicking 'Check for Updates' on the Plugins page is the preferred way to upgrade.

 

This is an extensive unRAID OS security and package update release.  In particular, we have made numerous changes to harden the unRAID OS webGui against XSS and CSRF vulnerabilities.

 

PREVIOUS unRAID OS RELEASES ARE VULNERABLE TO CSRF/XSS ATTACK AND WE STRONGLY RECOMMEND ALL USERS UPGRADE TO THIS RELEASE

 

Users upgrading from unRAID OS version 6.1.9 and below: please read the unRAID OS version 6 Upgrade Notes.

 

Plugin Authors: as posted earlier, your plugin may not function properly depending how how POST requests are handled, see:

http://lime-technology.com/forum/index.php?topic=55986.0

 

Plugin Users: please post issues you find in the appropriate Plugin Support topic.

 

And to reiterate: true plugins (not Docker containers) run as the

root

user and have full access to everything on your server: Install 3rd party plugins at your own risk.

 

Bugs: As always, if you are reporting a bug new in this release, please attach your diagnostics.zip file downloaded via Tools/Diagnostics

 


 

unRAID Server OS Change Log
===========================

Version 6.3.0 2017-02-02
------------------------

Management:

- emhttp: added 'svcs_restarting' event
- emhttp: include "vfs objects =" line for each share named in generated /etc/samba/smb-shared.conf file
- webGui: Fix regression changing display banner
- webGui: Fix regression with 'Compute All' on Share page

Version 6.3.0-rc9 2017-01-27
----------------------------

Base distro:

- add pv: version 1.6.0
- docker: version 1.12.6 (CVE-2016-9962)
- containerd: version 0.2.5
- glibc-zoneinfo: version 2016j
- gnutls: version 3.5.8 (CVE-2017-5334, CVE-2017-5335, CVE-2017-5336, CVE-2017-5337)
- libpng: version 1.6.27 (CVE-2016-10087)
- mozilla-firefox: version 51.0 (CVE-2017-5375, CVE-2017-5376, CVE-2017-5377, CVE-2017-5378, CVE-2017-5379, CVE-2017-5380, CVE-2017-5390, CVE-2017-5389, CVE-2017-5396, CVE-2017-5381, CVE-2017-5382, CVE-2017-5383, CVE-2017-5384, CVE-2017-5385, CVE-2017-5386, CVE-2017-5394, CVE-2017-5391, CVE-2017-5392, CVE-2017-5393, CVE-2017-5395, CVE-2017-5387, CVE-2017-5388, CVE-2017-5374, CVE-2017-5373)
- openssh: version 7.4p1 (CVE-2016-10009, CVE-2016-10010, CVE-2016-10011, CVE-2016-10012)
- php: version 7.0.15 (CVE-2016-10161, CVE-2016-10162, CVE-2017-5340, CVE-2016-7479, CVE-2016-10158, CVE-2016-10160, CVE-2016-10159)
- samba: version 4.5.3 (CVE-2016-2123, CVE-2016-2125, CVE-2016-2126)
- update hwdata/{pci.ids,usb.ids,oui.txt,manuf.txt}

Linux kernel:

- version 4.9.6
- added CONFIG_DRM_I915: Intel 8xx/9xx/G3x/G4x/HD Graphics (but blacklisted to prevent auto-load)

Management:

- libvirt: disable nested virtualizaton by default
- shfs: correct return value of system.LOCATION extended attribute to eliminate bash "warning: command substitution: ignored null byte in input"
- webGui: Add BTRFS file system checking notifications
- webGui: Avoid wget to cache plugin files and postpone plugin updates
- webGui: Capitalize method name in plugin operations.
- webGui: Natural sorting of user share names
- webGui: Save docker, VM and libvirt logs as .txt files in diagnostics
- webGui: Disable filesystem selection when data-rebuild is pending
- webGui: Add cache pool BTRFS info (if existing) to diagnostics
- webGui: added new Europe/Saratov timezone
- webGui: additional XSS and CSRF hardening

Version 6.3.0-rc6 2016-12-07
----------------------------

Base distro:

- inotify-tools: version 3.14
- mozilla-firefox: version 50.0.2 (CVE-2016-9078, CVE-2016-9079)
- ntfs-3g: version 2016.2.22
- rsyslog: version 8.23.0

Linux kernel:

- version 4.8.12 (CVE-2016-8650)

Management:

- network: must set forwarding delay before setting stp 'on'; need 1 sec delay between stop/start in restart
- samba: move OS X "vfs_fruit" optimization from 'global' to individual share settings
- shutdown: increase default shutdown delay from 60 to 90 sec; eliminate extraneous console messages
- update: hwdata/{pci.ids,usb.ids,oui.txt,manuf.txt} smartmontools/drivedb.h
- webGui: add Hibernate option to VM context menu

Version 6.3.0-rc5 2016-11-25
----------------------------

Base distro:

- bash: version 4.4.005
- grep: version 2.26 (rev2)
- kernel-firmware: version 20161118git
- libvirt: version 2.4.0
- mozilla-firefox: version 50.0
- ntp: version 4.2.8p9 (CVE-2016-9311, CVE-2016-9310, CVE-2016-7427, CVE-2016-7428, CVE-2016-9312, CVE-2016-7431, CVE-2016-7434, CVE-2016-7429, CVE-2016-7426, CVE-2016-7433)

Linux kernel:

- version 4.8.10 (CVE-2016-7039)

Management:

- add btrfs_check script to facilitate btrfs file system check
- bug fix: firefox correctly connects to emhttp port number
- samba: include OS X vfs_fruit optimizations by default
- shutdown: bug fix: overall shutdown timeout read from wrong cfg file
- shutdown: bug fix: saving shutdown timeout value
- shutdown: add config setting for overall VM shutdown timeout
- update: hwdata/{pci.ids,usb.ids,oui.txt,manuf.txt} smartmontools/drivedb.h
- webGui: add filesystem Check for btrfs volumes in Maintenance mode
- webGui: add vm shutdown time-out option
- webGui: generate VM xml with cpu topology as single-threaded when host cpu is AMD
- webGui: special text aside new disks to clear
- webGui: split out Europe/Istanbul as its own timezone

Other:

- make_bootable_linux: use readlink instead of realpath since it is more compatible

Version 6.3.0-rc4 2016-11-11
----------------------------

Base distro:

- curl: version 7.51.0 (CVE-2016-8615, CVE-2016-8616, CVE-2016-8617, CVE-2016-8618, CVE-2016-8619, CVE-2016-8620, CVE-2016-8621, CVE-2016-8622, CVE-2016-8623, CVE-2016-8624, CVE-2016-8625)
- docker: version 1.12.3 (CVE-2016-8867)
- glibc-zoneinfo: version 2016i
- grep: version 2.26
- kernel-firmware: version 20161001git
- libusb: version 1.0.21
- libX11: version 1.6.4 (CVE-2016-7942, CVE-2016-7943)
- libXfixes: version 5.0.3 (CVE-2016-7944)
- libXi: version 1.7.8 (CVE-2016-7945, CVE-2016-7946)
- libXrandr: version 1.5.1 (CVE-2016-7947, CVE-2016-7948)
- libXrender: version 0.9.10 (CVE-2016-7949, CVE-2016-7950)
- libXtst: version 1.2.3 (CVE-2016-7951, CVE-2016-7952)
- libXv: version 1.0.11 (CVE-2016-5407)
- lvm2: version 2.02.166
- mozilla-firefox: version 49.0.2
- mpfr: version 3.1.5
- nano: version 2.7.1
- php: version 7.0.13
- samba: version 4.5.1

Linux kernel:

- version 4.8.7 (CVE-2016-7042, CVE-2016-8630, CVE-2016-8633)
- md/unraid version: 2.7.1
  - make the 'check' command "correct"/"nocorrect" argument case insensitive
  - mark superblock 'clean' upon initialization

Management:

- emhttp: add API command cmdStopMover and API status variable shareMoverActive (yes/no)
- emhttp: ensure disk shares have proper permissions set even if not being exported
- emhttp: fix detecton of unclean shutdown to trigger automatic parity check upon Start if necessary
- emhttp: fix mac address not set in avahi afp share advertisement (regression introduced in -rc2)
- emhttp: unmount docker/libvirt loopback if docker/libvirt fail to start properly
- mover: add start/stop/status subcommands (experimental)
- mover: dereference files on user shares to get st_dev/st_ino instead of from shfs stat structure
- shfs: eliminate 'use_ino' option dependency (fixes NFS issue on buggy clients)
- update: hwdata/{pci.ids,usb.ids,oui.txt,manuf.txt} smartmontools/drivedb.h
- webGui: combine PCI Devices and IOMMU Groups on Sysdev page; Sort IOMMU and USB Devices properly
- webGui: correct button positions on confirmation dialogs
- webGui: correct handling of unclean shutdown detection
- webGui: fixed device passthrough for Docker
- webGui: fixed Docker/VMs tab stay visible when array is stopped
- webGui: fixed some help text typos
- webGui: update to font-awesome 4.7.0

Version 6.3.0-rc3 2016-10-22
----------------------------

Linux kernel:

- version 4.8.4 (CVE-2016-5195)

Management:

- shutdown: additional logging in event of cmdStop timeout

Version 6.3.0-rc2 2016-10-19
----------------------------

Base distro:

- docker: version 1.12.2
- containerd: version 0.2.4
- runc: version 1.0.0_rc2
- libseccomp: version 2.3.1
- libvirt-php: 0.5.2 (+ latest from git)
- php: version 7.0.12
- usbredir: version 0.7.1
- spice: version 0.12.8
- spice-protocol: version 0.12.12
- imlib2: version 1.4.9
- gd: version 2.2.3
- rsyslog: version 8.22.0
- libfastjson: version 0.99.4
- reverted OVMF firmware back to the version in 6.2 due to user reported issues

Linux kernel:

- version 4.8.2
- r750: version 1.2.10-16_10_13
- md/unraid: kernel 4.8 API changes; support FUA and SYNC write operation flags

Management:

- bug fix: Samba listening on the wrong interface in a VLAN-enable config
- emhttp: added starting/stopping docker/libvirt events
- emhttp: removed 'reboot', 'shutdown', 'changeNetwork' API calls; eliminated emhttp-managed network vars
- shutdown: save diagnostics in event of cmdStop timeout
- vm manager: add 'virtio-win-0.1.126-2' and 'virtio-win-0.1.126-1' to VirtIO-ISOs list
- webGui: Added "Join" notification agent
- webGui: Add support for "Notify My Android" notifications
- webGui: Fixed: Windows unable to extract diagnostics zip file
- webGui: Increased password length to 128 characters
- webGui: Interactive Reboot and Shutdown directly invokes '/sbin/reboot' and '/sbin/poweroff'

Version 6.3.0-rc1 2016-10-05
----------------------------

Base distro (primary packages):

- btrfs-progs: version v4.7.2
- netatalk: version 3.1.10
- openssl: version 1.0.2j
- php: version 5.6.26
- qemu: version 2.7.0
- samba: version 4.5.0

Base distro (secondary packages):

- apcupsd: version 3.14.14
- bash: version 4.4.0
- curl: version 7.50.3
- diffutils: version 3.5
- e2fsprogs: version 1.43.3
- etc: version 14.2
- file: version 5.28
- fuse: version 2.9.7
- gawk: version 4.1.4
- gdbm: version 1.12
- glib2: version 2.46.2
- glibc: version 2.24
- glibc: version zoneinfo
- glibc-solibs: version 2.24
- gnutls: version 3.4.15
- jemalloc: version 4.2.1
- kmod: version 23
- libtasn1: version 4.9
- libxml2: version 2.9.4
- lvm2: version 2.02.161
- nano: version 2.7.0
- network-scripts: version 14.2
- nfs-utils: version 1.3.4
- openssl-solibs version: 1.0.2j
- pkgtools-14.2-noarch: version 13
- reiserfsprogs: version 3.6.25
- util-linux: version 2.28.2

Base distro (desktop GUI packages):

- freetype: version 2.6.5
- harfbuzz: version 1.3.0
- libXfont: version 1.5.2
- mesa: version 12.0.2
- mozilla-firefox: version 49.0.1
- xkeyboard-config: version 2.18
- xorg-server: version 1.18.4

Linux kernel:

- version 4.7.6
- aacraid: version 1.2.1-52011
- intel 10Gbit ethernet: revert to in-tree drivers
- r750: version 1.2.9-16_09_27
- md/unraid: Fix bug where case of no data disks improperly detected.

Management:

- bug fix: For file system type "auto", only attempt btrfs,xfs,reiserfs mounts.
- bug fix: For docker.img and libvirt.img, if path on /mnt/ check for mountpoint on any subdir component
- bug fix: During shutdown force continue if array stop taking too long.
- bug fix: Handle case in 'mover' where rsync may move a file but also return error status.
- webGui: Add "Shutdown time-out" control on Disk Settings page.
- webGui: bug fix: Cannot manually specify virtIO iso in VM settings
- webGui: other changes: refer to github commit log

Link to comment
  • Replies 323
  • Created
  • Last Reply

Top Posters In This Topic

Top Posters In This Topic

Posted Images

Trying to install over RC9, and get this message:

 

plugin: installing: https://raw.githubusercontent.com/limetech/unRAIDServer/master/unRAIDServer.plg
plugin: downloading https://raw.githubusercontent.com/limetech/unRAIDServer/master/unRAIDServer.plg
plugin: downloading: https://raw.githubusercontent.com/limetech/unRAIDServer/master/unRAIDServer.plg ... done
plugin: not installing older version

 

 

Link to comment

Trying to install over RC9, and get this message:

 

plugin: installing: https://raw.githubusercontent.com/limetech/unRAIDServer/master/unRAIDServer.plg
plugin: downloading https://raw.githubusercontent.com/limetech/unRAIDServer/master/unRAIDServer.plg
plugin: downloading: https://raw.githubusercontent.com/limetech/unRAIDServer/master/unRAIDServer.plg ... done
plugin: not installing older version

 

Ditto

Link to comment

Trying to install over RC9, and get this message:

 

plugin: installing: https://raw.githubusercontent.com/limetech/unRAIDServer/master/unRAIDServer.plg
plugin: downloading https://raw.githubusercontent.com/limetech/unRAIDServer/master/unRAIDServer.plg
plugin: downloading: https://raw.githubusercontent.com/limetech/unRAIDServer/master/unRAIDServer.plg ... done
plugin: not installing older version

 

We'll look into that.  You can install the "old fashioned" way: open zip file, drag over bzimage, bzroot, bzroot-gui from zip to flash share, then reboot.

Link to comment

I'm working on the new recycle bin plugin and as soon as I install it I get this error:

 

HTTP/1.1 200 OK Server: emhttp Connection: close Content-Type: text/html; charset=utf-8 Cache-Control: no-cache X-Frame-Options: SAMEORIGIN

 

Can you give me a clue where to look for the source of this error?  It worked on rc9.

Link to comment

I installed the update coming from v6.2.4. One of my VM's would not start due to an "Invalid Machine Type" error. I knew what the error was right away. Changed the machine type in the XML from:

 

<type arch='x86_64' machine='pc-q35-2.3'>hvm</type>

 

to:

 

<type arch='x86_64' machine='pc-q35-2.7'>hvm</type>

 

and then it started up just fine. Yeah, it was and old VM created ages ago! Just thought I'd mention it in case anyone else runs into this problem.

 

Thanks for the great release as always!

 

Gary

Link to comment

I'm working on the new recycle bin plugin and as soon as I install it I get this error:

 

HTTP/1.1 200 OK Server: emhttp Connection: close Content-Type: text/html; charset=utf-8 Cache-Control: no-cache X-Frame-Options: SAMEORIGIN

 

Can you give me a clue where to look for the source of this error?  It worked on rc9.

 

The existence of the svcs_restarting script causes this error.  If I remove it from the /usr/lcoal/emhttp/plugins/recycle.bin/event folder the error disappears.

Link to comment

I'm working on the new recycle bin plugin and as soon as I install it I get this error:

 

HTTP/1.1 200 OK Server: emhttp Connection: close Content-Type: text/html; charset=utf-8 Cache-Control: no-cache X-Frame-Options: SAMEORIGIN

 

Can you give me a clue where to look for the source of this error?  It worked on rc9.

 

The existence of the svcs_restarting script causes this error.  If I remove it from the /usr/lcoal/emhttp/plugins/recycle.bin/event folder the error disappears.

 

Where does this message appear?  system log?  console?  What is the script doing?

Link to comment

I'm working on the new recycle bin plugin and as soon as I install it I get this error:

 

HTTP/1.1 200 OK Server: emhttp Connection: close Content-Type: text/html; charset=utf-8 Cache-Control: no-cache X-Frame-Options: SAMEORIGIN

 

Can you give me a clue where to look for the source of this error?  It worked on rc9.

 

The existence of the svcs_restarting script causes this error.  If I remove it from the /usr/lcoal/emhttp/plugins/recycle.bin/event folder the error disappears.

 

Where does this message appear?  system log?  console?  What is the script doing?

 

On top of the webgui.

Link to comment

I'm working on the new recycle bin plugin and as soon as I install it I get this error:

 

HTTP/1.1 200 OK Server: emhttp Connection: close Content-Type: text/html; charset=utf-8 Cache-Control: no-cache X-Frame-Options: SAMEORIGIN

 

Can you give me a clue where to look for the source of this error?  It worked on rc9.

 

The existence of the svcs_restarting script causes this error.  If I remove it from the /usr/lcoal/emhttp/plugins/recycle.bin/event folder the error disappears.

 

Where does this message appear?  system log?  console?  What is the script doing?

 

On top of the webgui.

Can you post the script?

Link to comment

I'm working on the new recycle bin plugin and as soon as I install it I get this error:

 

HTTP/1.1 200 OK Server: emhttp Connection: close Content-Type: text/html; charset=utf-8 Cache-Control: no-cache X-Frame-Options: SAMEORIGIN

 

Can you give me a clue where to look for the source of this error?  It worked on rc9.

 

The existence of the svcs_restarting script causes this error.  If I remove it from the /usr/lcoal/emhttp/plugins/recycle.bin/event folder the error disappears.

 

Where does this message appear?  system log?  console?  What is the script doing?

 

On top of the webgui.

 

It looks like when I remove the svcs_restarting script, the smb-share.conf go back to before I add my changes..

Link to comment

Recycle bin svcs_restarting script:

#!/bin/bash
#
/usr/local/emhttp/plugins/recycle.bin/scripts/configure_recycle_bin

# read our configuration.
plugin="recycle.bin"
CONFIG="/boot/config/plugins/${plugin}/${plugin}.cfg"
source $CONFIG

DIR="/etc/samba/unassigned-shares/"
if [ -d "$DIR" ]; then
FILES=("$DIR"*)

for i in "${FILES[@]}"
do
	/usr/local/emhttp/plugins/recycle.bin/scripts/configure_recycle_bin "$i"
done
fi

 

configure_recycle_bin script:

#!/usr/bin/php
<?PHP
/* Copyright 2017, Dan Landon
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License version 2,
* as published by the Free Software Foundation.
*
* The above copyright notice and this permission notice shall be included in
* all copies or substantial portions of the Software.
*/
?>

<?

// Get the recycle bin concifuration.
$recycle_bin_cfg = parse_ini_file( "/boot/config/plugins/recycle.bin/recycle.bin.cfg" );

if (isset($argv[1])) {
$smb_file = $argv[1];
$ud_config_file = TRUE;
} else {
$smb_file =  "/etc/samba/smb-shares.conf";
$ud_config_file = FALSE;
}

if (!is_file($smb_file)) {
$smb_file = "";
}

echo "$smb_file\n";

// If smb_file is not defined then there is nothing to configure
if ($smb_file != "") {
// Array of recycle bin parameters
$parms =  array("recycle:repository"		=> "%P/.Recycle.Bin/",
				"recycle:directory_mode"	=> "0777",
				"recycle:keeptree"			=> "Yes",
				"recycle:touch"				=> "Yes",
				"recycle:touch_mtime"		=> "Yes",
				"recycle:versions"			=> "Yes",
				"recycle:exclude"			=> "",   
				"recycle:exclude_dir"		=> ".Recycle.Bin"
);

// Adjust user set parameters.
if ($recycle_bin_cfg['LOG'] == "yes") {
	$vfs_objects = " extd_audit recycle";
} else {
	$vfs_objects = " recycle";
}

// Set the excluded files.
$parms['recycle:exclude'] = $recycle_bin_cfg['EXCLUDE'];

// Adjust repository with user parameters.
$parms['recycle:repository'] .= $recycle_bin_cfg['PARAMETERS'];

// Parse the samba config file.
$smb_config = parse_ini_file($smb_file, true, INI_SCANNER_RAW);

// Get the excluded files from recycle bin configuration.
$excluded_shares = explode(',', $recycle_bin_cfg['EXCLUDE_SHARES']);

// Get all shares from the smb configuration file.
$smb_shares = array_keys($smb_config);

// Remove excluded shares.
$shares = array_diff($smb_shares, $excluded_shares);

if ($ud_config_file) {
	// Remove recycle bin parameters from the UD coonfiguration.
	foreach ($shares as $s) {
		if (isset($smb_config[$s]['vfs objects'])) {
			$smb_config[$s]['vfs objects'] = "";
		}
		$parms_keys = array_keys($parms);
		foreach ($parms_keys as $key) {
			if (isset($smb_config[$s][$key])) {
				unset($smb_config[$s][$key]);
			}
		}
	}

	// Add ud parameters if recycle bin is running and UD shares are included.
	if (is_file("/var/run/recycle.bin/recycle.bin.pid") && ($recycle_bin_cfg['INCLUDE_UD'] == 'yes')) {
		// Add vfs objects and recycle bin parameters.
		foreach ($shares as $s) {
			if ((isset($smb_config[$s]['vfs objects'])) && ($smb_config[$s]['vfs objects'] == "")) {
				$smb_config[$s]['vfs objects'] .= $vfs_objects;
				$smb_config[$s]['vfs objects'] = trim($smb_config[$s]['vfs objects']);
				$smb_config[$s] = array_merge($smb_config[$s], $parms);
			}
		}
	}
} else if (is_file("/var/run/recycle.bin/recycle.bin.pid")) {
	// Add vfs objects and recycle bin parameters.
	foreach ($shares as $s) {
		if (isset($smb_config[$s]['vfs objects'])) {
			$smb_config[$s]['vfs objects'] .= $vfs_objects;
			$smb_config[$s] = array_merge($smb_config[$s], $parms);
		}
	}
}

// Rewrite the configuration file.
$keys = array_keys($smb_config);
foreach ($keys as $key) {
	$iniFile .= "[$key]\n";
	$entryKeys = array_keys($smb_config[$key]);
	foreach ($entryKeys as $entry) {
		$iniFile .= "\t".$entry.' = '.$smb_config[$key][$entry]."\n";
	}
}

// Write the new configuration.
file_put_contents($smb_file, $iniFile);
}
?>

Link to comment

If I remove the configure_recycle_bin script, the error goes away also.

 

The thing to do is simplify the script, commenting out/removing code until that message is not produced anymore.  Also I don't think it's valid to use parse_ini_file() on the smb-shares.conf file because I don't think it will work properly with identifiers that are valid for Samba but not php, eg, if a share name has a '$' character in it, or if a variable has a ':' character in it.

Link to comment

If I remove the configure_recycle_bin script, the error goes away also.

 

The thing to do is simplify the script, commenting out/removing code until that message is not produced anymore.  Also I don't think it's valid to use parse_ini_file() on the smb-shares.conf file because I don't think it will work properly with identifiers that are valid for Samba but not php, eg, if a share name has a '$' character in it, or if a variable has a ':' character in it.

 

I'll give that a try and also look into the special characters in the names.  Is there a better parsing routine I can use or am I going to have to write on on my own?  I'm also getting these log messages every minute:

Feb 3 23:24:02 BackupServer emhttp: 
Feb 3 23:25:01 BackupServer emhttp: 
Feb 3 23:26:01 BackupServer emhttp: 

Link to comment

I had to change this:

<?PHP
/* Copyright 2017, Dan Landon
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License version 2,
* as published by the Free Software Foundation.
*
* The above copyright notice and this permission notice shall be included in
* all copies or substantial portions of the Software.
*/
?>

<?
// Get the recycle bin concifuration.
$recycle_bin_cfg = parse_ini_file( "/boot/config/plugins/recycle.bin/recycle.bin.cfg" );

 

To this:

<?PHP
/* Copyright 2017, Dan Landon
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License version 2,
* as published by the Free Software Foundation.
*
* The above copyright notice and this permission notice shall be included in
* all copies or substantial portions of the Software.
*/

// Get the recycle bin concifuration.
$recycle_bin_cfg = parse_ini_file( "/boot/config/plugins/recycle.bin/recycle.bin.cfg" );

 

What's up with that?

Link to comment

If I remove the configure_recycle_bin script, the error goes away also.

 

The thing to do is simplify the script, commenting out/removing code until that message is not produced anymore.  Also I don't think it's valid to use parse_ini_file() on the smb-shares.conf file because I don't think it will work properly with identifiers that are valid for Samba but not php, eg, if a share name has a '$' character in it, or if a variable has a ':' character in it.

 

I am reading the ini file raw so nothing is being parsed:

$smb_config = parse_ini_file($smb_file, true, INI_SCANNER_RAW);

 

It respects the special characters.  I ran a test and it does work.

Link to comment

I had to change this:

<?PHP
/* Copyright 2017, Dan Landon
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License version 2,
* as published by the Free Software Foundation.
*
* The above copyright notice and this permission notice shall be included in
* all copies or substantial portions of the Software.
*/
?>

<?
// Get the recycle bin concifuration.
$recycle_bin_cfg = parse_ini_file( "/boot/config/plugins/recycle.bin/recycle.bin.cfg" );

 

To this:

<?PHP
/* Copyright 2017, Dan Landon
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License version 2,
* as published by the Free Software Foundation.
*
* The above copyright notice and this permission notice shall be included in
* all copies or substantial portions of the Software.
*/

// Get the recycle bin concifuration.
$recycle_bin_cfg = parse_ini_file( "/boot/config/plugins/recycle.bin/recycle.bin.cfg" );

 

What's up with that?

 

In a php cli script any text outside <? .. ?> is simply sent to stdout.  Any output generated by an emhttp_event script is sent to the connection socket as "log lines".  For example if your script does this:

 

echo "hello world";

 

Then this is written to the connection socket:

 

"<script>addLog(\"hello world\");</script>"

 

In the normal case this shows up in the "progress frame" - the area at the bottom of the browser page.  Could be maybe this is broken - I'll look into, but in meantime you should ensure your script doesn't output anything to stdout or stderr.

Link to comment

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.